Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add online docs badge to readme #28

Merged
merged 1 commit into from
Dec 4, 2019
Merged

add online docs badge to readme #28

merged 1 commit into from
Dec 4, 2019

Conversation

weikang9009
Copy link
Member

jGaboardi
jGaboardi reviewed Dec 3, 2019
View reviewed changes
Copy link
Member

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The video on the home page is really cool. Could we make the video panel fit a bit better (or make it flexible)? The right edge is being cut off depending on the zoom level:

luc_cut

@jGaboardi jGaboardi added this to the next release milestone Dec 3, 2019
jGaboardi
jGaboardi approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I will go ahead and approve. This is nice!

@weikang9009
Copy link
Member Author

The video on the home page is really cool. Could we make the video panel fit a bit better (or make it flexible)? The right edge is being cut off depending on the zoom level:

luc_cut

I think @ljwolf added this very cool video!

@weikang9009 weikang9009 merged commit 0f330d8 into pysal:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jGaboardi jGaboardi jGaboardi approved these changes

@pedrovma pedrovma Awaiting requested review from pedrovma

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
next release
Development

Successfully merging this pull request may close these issues.
2 participants
@weikang9009 @jGaboardi