Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit for style checks and use black as formatter #169

Merged
merged 7 commits into from
Aug 3, 2018
Merged

Add pre-commit for style checks and use black as formatter #169

merged 7 commits into from
Aug 3, 2018

Conversation

nicoddemus
Copy link
Member

  • Add instructions about developing with pip install -e .[dev]
  • Add pre-commit for checks
  • Use black for formatting code and docs
  • Change tox env "check" to "linting", using pre-commmit to do the actual checks
  • Add "black" badge to readme

goodboy
goodboy approved these changes Aug 3, 2018
View reviewed changes
Copy link
Contributor

@goodboy goodboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm now that's quite the clean up.
Nice job 👍

@nicoddemus
Copy link
Member Author

nicoddemus commented Aug 3, 2018 •
edited
Loading

The AppVeyor is unrelated: benhoyt/scandir#106, benhoyt/scandir#107

@goodboy goodboy merged commit 6587ed0 into pytest-dev:master Aug 3, 2018
@nicoddemus nicoddemus deleted the pre-commit-black branch August 3, 2018 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

@goodboy goodboy goodboy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicoddemus @RonnyPfannschmidt @goodboy