Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testing for pypy3 #188

Merged
merged 2 commits into from
Feb 16, 2019
Merged

Add testing for pypy3 #188

merged 2 commits into from
Feb 16, 2019

Conversation

nicoddemus
Copy link
Member

Fix #187

@goodboy
Copy link
Contributor

goodboy commented Jan 28, 2019

Looks like someone has to fix the actual bug now, heh.

@nicoddemus
Copy link
Member Author

Heh yeah, I will take a look later

@RonnyPfannschmidt
Copy link
Member

while this doesn't affect pytest, its still nice to see it fixed

@nicoddemus
Copy link
Member Author

@RonnyPfannschmidt @tgoodlet gentle ping. 😁

goodboy
goodboy approved these changes Feb 16, 2019
View reviewed changes
Copy link
Contributor

@goodboy goodboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job as always @nicoddemus 👍

@goodboy goodboy merged commit 9a12ad4 into pytest-dev:master Feb 16, 2019
@nicoddemus nicoddemus deleted the pypy3 branch February 16, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueyed blueyed blueyed approved these changes

@goodboy goodboy goodboy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicoddemus @goodboy @RonnyPfannschmidt @blueyed