Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should master terminology be replaced with controller? #592

Open
bashtage opened this issue Aug 27, 2020 · 1 comment
Open

Should master terminology be replaced with controller? #592

bashtage opened this issue Aug 27, 2020 · 1 comment

Comments

@bashtage
Copy link

I saw in the changelog that references to slave were removed in 2.0.0. I also noticed that functions referencing the counterpart to slave, master, were introduced.

Should master be replaced with a more neutral term such as controller (or something similar)?

It is also worth noting that git is moving away from master as the default branch and GitHub is moving to main as the default branch.

@RonnyPfannschmidt
Copy link
Member

i started taking a loo, its a very unfortunate oversight, but its a breaking change for get_xdist_worker_id for now

RonnyPfannschmidt added a commit that referenced this issue Feb 11, 2021
prepare #592: replace master with controller where we can
gcf-merge-on-green bot referenced this issue in GoogleCloudPlatform/python-docs-samples Aug 3, 2021
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pytest-xdist](https://togithub.com/pytest-dev/pytest-xdist) | `==2.2.1` -> `==2.3.0` | [![age](https://badges.renovateapi.com/packages/pypi/pytest-xdist/2.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/pytest-xdist/2.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/pytest-xdist/2.3.0/compatibility-slim/2.2.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/pytest-xdist/2.3.0/confidence-slim/2.2.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>pytest-dev/pytest-xdist</summary>

### [`v2.3.0`](https://togithub.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst#pytest-xdist-230-2021-06-16)

[Compare Source](https://togithub.com/pytest-dev/pytest-xdist/compare/v2.2.1...v2.3.0)

\===============================

## Deprecations and Removals

-   `#&#8203;654 <https://github.com/pytest-dev/pytest-xdist/issues/654>`\_: Python 3.5 is no longer supported.

## Features

-   `#&#8203;646 <https://github.com/pytest-dev/pytest-xdist/issues/646>`\_: Add `--numprocesses=logical` flag, which automatically uses the number of logical CPUs available, instead of physical CPUs with `auto`.

    This is very useful for test suites which are not CPU-bound.

-   `#&#8203;650 <https://github.com/pytest-dev/pytest-xdist/issues/650>`\_: Added new `pytest_handlecrashitem` hook to allow handling and rescheduling crashed items.

## Bug Fixes

-   `#&#8203;421 <https://github.com/pytest-dev/pytest-xdist/issues/421>`\_: Copy the parent process sys.path into local workers, to work around execnet's python -c adding the current directory to sys.path.

-   `#&#8203;638 <https://github.com/pytest-dev/pytest-xdist/issues/638>`\_: Fix issue caused by changing the branch name of the pytest repository.

## Trivial Changes

-   `#&#8203;592 <https://github.com/pytest-dev/pytest-xdist/issues/592>`\_: Replace master with controller where ever possible.

-   `#&#8203;643 <https://github.com/pytest-dev/pytest-xdist/issues/643>`\_: Use 'main' to refer to pytest default branch in tox env names.

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/GoogleCloudPlatform/python-docs-samples).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants