Multiple code quality improvements #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostming
requested changes
Jul 19, 2022
- removed `exclude` from `pycln` pre-commit config - removed adding of futture-annotations import from isort config - added `TOMLDocument` to `__all__` list in tomlkit/__init__.py
…de)" This reverts commit 60abdac.
Secrus
changed the title
Secrus
changed the title
capuanob
pushed a commit
to capuanob/tomlkit
that referenced
this pull request
Mar 1, 2023
* Add pre-commit config * First pre-commit swipe (isort, flake8-bugbear, black, pyupgrade) * Flake8-broken-line and flake8-comprehensions * Flake8-eradicate, flake8-simplify, pep8-naming * flake8-use-fstring * flake8-tidy-imports, flake8-quotes * flake8-typing-imports, flake8-type-checking * pycln * Remove unnecessary comments * Update versions of plugins * Code review changes - removed `exclude` from `pycln` pre-commit config - removed adding of futture-annotations import from isort config - added `TOMLDocument` to `__all__` list in tomlkit/__init__.py * Revert "First pre-commit swipe (isort, flake8-bugbear, black, pyupgrade)" This reverts commit 60abdac. * Remove unnecessary option * Remove unnecessary isort config option * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake8plugins and corrected issues that raisedpyupgrade(set to 3.6+)pyclnlinter