-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop 3.8 support #3106
Drop 3.8 support #3106
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3106 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 121 121
Lines 18155 18167 +12
Branches 3270 3268 -2
=======================================
+ Hits 18080 18092 +12
Misses 52 52
Partials 23 23
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed something that's technically 3.9 incompatible, but probably not in practice. For test_path
, you'll just want to add (pathlib.Path, trio.Path)
so that combo gets tested.
Currently fails because of assert that return type is |
Co-authored-by: Spencer Brown <[email protected]>
This reverts commit 8dec4d4.
Once again ran into the bad cache for CI jobs thing. I really wonder what could be causing it; seems to be some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically just nitpicks.
Co-authored-by: A5rocks <[email protected]>
Co-authored-by: Spencer Brown <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect most from __future__ import annotations
could be removed, but /shrug
Co-authored-by: jakkdl <[email protected]> Co-authored-by: Spencer Brown <[email protected]>
Co-authored-by: Spencer Brown <[email protected]>
Closes #3104, this pull request aims to handle dropping python 3.8 support and the various changes we can now make with that.
One thing I'm not sure how to handle, see
src/trio/_tests/test_path.py:81