Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop 3.8 support #3106

Merged
merged 16 commits into from
Oct 21, 2024
Merged

Drop 3.8 support #3106

merged 16 commits into from
Oct 21, 2024

Conversation

CoolCat467
Copy link
Member

Closes #3104, this pull request aims to handle dropping python 3.8 support and the various changes we can now make with that.

One thing I'm not sure how to handle, see
src/trio/_tests/test_path.py:81

@CoolCat467 CoolCat467 requested a review from jakkdl October 9, 2024 20:26
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (c47758c) to head (507dee3).
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3106   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files         121      121           
  Lines       18155    18167   +12     
  Branches     3270     3268    -2     
=======================================
+ Hits        18080    18092   +12     
  Misses         52       52           
  Partials       23       23           
Files with missing lines Coverage Δ
src/trio/_channel.py 100.00% <ø> (ø)
src/trio/_core/_asyncgens.py 100.00% <ø> (ø)
src/trio/_core/_entry_queue.py 100.00% <100.00%> (ø)
src/trio/_core/_instrumentation.py 100.00% <100.00%> (ø)
src/trio/_core/_io_kqueue.py 87.20% <100.00%> (ø)
src/trio/_core/_io_windows.py 98.80% <ø> (ø)
src/trio/_core/_tests/test_guest_mode.py 100.00% <100.00%> (ø)
src/trio/_core/_tests/test_instrumentation.py 100.00% <100.00%> (ø)
src/trio/_core/_tests/test_io.py 100.00% <100.00%> (ø)
src/trio/_core/_tests/test_ki.py 97.83% <100.00%> (ø)
... and 27 more

Copy link
Contributor

@TeamSpen210 TeamSpen210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed something that's technically 3.9 incompatible, but probably not in practice. For test_path, you'll just want to add (pathlib.Path, trio.Path) so that combo gets tested.

@CoolCat467
Copy link
Member Author

For test_path, you'll just want to add (pathlib.Path, trio.Path) so that combo gets tested.

Currently fails because of assert that return type is trio.Path

@CoolCat467 CoolCat467 requested a review from A5rocks October 16, 2024 19:33
@A5rocks
Copy link
Contributor

A5rocks commented Oct 16, 2024

Once again ran into the bad cache for CI jobs thing. I really wonder what could be causing it; seems to be some pip thing?

Copy link
Contributor

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically just nitpicks.

Copy link
Member

@jakkdl jakkdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect most from __future__ import annotations could be removed, but /shrug

@CoolCat467 CoolCat467 requested a review from jakkdl October 21, 2024 03:59
@CoolCat467 CoolCat467 merged commit af010af into python-trio:main Oct 21, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop python3.8 support
4 participants