Skip to content

Commit

Permalink
Revert "bpo-38811: Check for presence of os.link method in pathlib. (G…
Browse files Browse the repository at this point in the history
…H-17170)"

This reverts commit 111772f.
  • Loading branch information
vstinner authored Nov 18, 2019
1 parent 04c79d6 commit bd90969
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 27 deletions.
8 changes: 1 addition & 7 deletions Lib/pathlib.py
Original file line number Diff line number Diff line change
Expand Up @@ -418,12 +418,7 @@ def lchmod(self, pathobj, mode):

unlink = os.unlink

if hasattr(os, "link"):
link_to = os.link
else:
@staticmethod
def link_to(self, target):
raise NotImplementedError("os.link() not available on this system")
link_to = os.link

rmdir = os.rmdir

Expand All @@ -435,7 +430,6 @@ def link_to(self, target):
if supports_symlinks:
symlink = os.symlink
else:
@staticmethod
def symlink(a, b, target_is_directory):
raise NotImplementedError("symlink() not available on this system")
else:
Expand Down
19 changes: 0 additions & 19 deletions Lib/test/test_pathlib.py
Original file line number Diff line number Diff line change
Expand Up @@ -1759,7 +1759,6 @@ def test_rmdir(self):
self.assertFileNotFound(p.stat)
self.assertFileNotFound(p.unlink)

@unittest.skipUnless(hasattr(os, "link"), "os.link() is not present")
def test_link_to(self):
P = self.cls(BASE)
p = P / 'fileA'
Expand All @@ -1779,15 +1778,6 @@ def test_link_to(self):
self.assertEqual(os.stat(r).st_size, size)
self.assertTrue(q.stat)

@unittest.skipIf(hasattr(os, "link"), "os.link() is present")
def test_link_to_not_implemented(self):
P = self.cls(BASE)
p = P / 'fileA'
# linking to another path.
q = P / 'dirA' / 'fileAA'
with self.assertRaises(NotImplementedError):
p.link_to(q)

def test_rename(self):
P = self.cls(BASE)
p = P / 'fileA'
Expand Down Expand Up @@ -2021,15 +2011,6 @@ def test_symlink_to(self):
self.assertTrue(link.is_dir())
self.assertTrue(list(link.iterdir()))

@unittest.skipIf(support.can_symlink(), "symlink support is present")
def test_symlink_to_not_implemented(self):
P = self.cls(BASE)
target = P / 'fileA'
# Symlinking a path target.
link = P / 'dirA' / 'linkAA'
with self.assertRaises(NotImplementedError):
link.symlink_to(target)

def test_is_dir(self):
P = self.cls(BASE)
self.assertTrue((P / 'dirA').is_dir())
Expand Down

This file was deleted.

0 comments on commit bd90969

Please sign in to comment.