Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Multi-Phase Init for the _testinternalcapi Module #100997

Closed
ericsnowcurrently opened this issue Jan 12, 2023 · 4 comments
Closed

Implement Multi-Phase Init for the _testinternalcapi Module #100997

ericsnowcurrently opened this issue Jan 12, 2023 · 4 comments
Labels
3.12 bugs and security fixes extension-modules C modules in the Modules dir topic-subinterpreters type-feature A feature request or enhancement

Comments

@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Jan 12, 2023 •
edited by bedevere-bot
Loading

See PEP 630 and PEP 687. This is an internal test module so the bar isn't as high as for regular stdlib modules.

Linked PRs
@ericsnowcurrently ericsnowcurrently added type-feature A feature request or enhancement extension-modules C modules in the Modules dir topic-subinterpreters 3.12 bugs and security fixes labels Jan 12, 2023
@bedevere-bot bedevere-bot mentioned this issue Jan 12, 2023
Merged
ericsnowcurrently added a commit that referenced this issue Jan 12, 2023
@ericsnowcurrently
GH-100997: Implement Multi-Phase Init for the _testinternalcapi Module (
b511d35 
gh-100998)

_testinternalcapi is an internal module used for testing.

#100997
@kumaraditya303
Copy link
Contributor

With #100998 there are refleaks on main, reopening.

@bedevere-bot bedevere-bot mentioned this issue Jan 15, 2023
Merged
kumaraditya303 added a commit that referenced this issue Jan 16, 2023
@kumaraditya303
GH-100997: fix refleak in _testinternalcapi.c (#101058)
74c20b6
@ericsnowcurrently
Copy link
Member Author

The leak is fixed now, right?

@kumaraditya303
Copy link
Contributor

Yeah fixed by #101058

@ericsnowcurrently
Copy link
Member Author

Thanks!

@ericsnowcurrently ericsnowcurrently mentioned this issue Mar 28, 2023
Open
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 bugs and security fixes extension-modules C modules in the Modules dir topic-subinterpreters type-feature A feature request or enhancement
Projects
Subinterpreters
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericsnowcurrently @kumaraditya303