bpo-26978: Implement pathlib.Path.link_to (Using os.link) #12990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
approved these changes
Apr 28, 2019
|
cc @pitrou |
pitrou
requested changes
Apr 29, 2019
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @pitrou: please review the changes made to this pull request. |
tirkarthi
reviewed
May 4, 2019
pitrou
changed the title
pitrou
approved these changes
May 4, 2019
|
Thank you @nanjekyejoannah. I will wait for CI to pass and then merge if green. |
ZackerySpytz
reviewed
May 4, 2019
| @@ -334,6 +334,10 @@ pathlib | |||
| contain characters unrepresentable at the OS level. | |||
| (Contributed by Serhiy Storchaka in :issue:`33721`.) | |||
|
|
|||
| Added :meth:`pathlib.Path.link_to()` which creates a hard link pointing | |||
| to a path. | |||
| (Contributed by Joannah Nanjekye in :issue:`26978`) | |||
There was a problem hiding this comment.
Suggested change
| (Contributed by Joannah Nanjekye in :issue:`26978`) | |
| (Contributed by Joannah Nanjekye in :issue:`26978`.) |
ZackerySpytz
reviewed
May 4, 2019
| @@ -0,0 +1,2 @@ | |||
| `pathlib.path.link_to()` is now implemented. It creates a hard link pointing | |||
There was a problem hiding this comment.
It should be pathlib.Path.link_to(), not pathlib.path.link_to().
Also, double backqoutes should be used here instead of single backquotes (as per https://devguide.python.org/documenting/#inline-markup). The following could also be used:
:meth:`pathlib.Path.link_to()`
tohojo
added a commit
to tohojo/cpython
that referenced
this pull request
Nov 16, 2019
Commit 6b5b013 ("bpo-26978: Implement pathlib.Path.link_to (Using os.link) (pythonGH-12990)") introduced a new link_to method in pathlib. However, this makes pathlib crash when the 'os' module is missing a 'link' method. Fix this by checking for the presence of the 'link' method on pathlib module import, and if it's not present, turn it into a runtime error like those emitted when there is no lchmod() or symlink(). Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
tohojo
added a commit
to tohojo/cpython
that referenced
this pull request
Nov 18, 2019
Commit 6b5b013 ("bpo-26978: Implement pathlib.Path.link_to (Using os.link) (pythonGH-12990)") introduced a new link_to method in pathlib. However, this makes pathlib crash when the 'os' module is missing a 'link' method. Fix this by checking for the presence of the 'link' method on pathlib module import, and if it's not present, turn it into a runtime error like those emitted when there is no lchmod() or symlink(). Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
vstinner
pushed a commit
that referenced
this pull request
Dec 16, 2019
Commit 6b5b013 ("bpo-26978: Implement pathlib.Path.link_to (Using os.link) (GH-12990)") introduced a new link_to method in pathlib. However, this makes pathlib crash when the 'os' module is missing a 'link' method. Fix this by checking for the presence of the 'link' method on pathlib module import, and if it's not present, turn it into a runtime error like those emitted when there is no lchmod() or symlink(). Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 16, 2019
…17225) Commit 6b5b013 ("bpo-26978: Implement pathlib.Path.link_to (Using os.link) (pythonGH-12990)") introduced a new link_to method in pathlib. However, this makes pathlib crash when the 'os' module is missing a 'link' method. Fix this by checking for the presence of the 'link' method on pathlib module import, and if it's not present, turn it into a runtime error like those emitted when there is no lchmod() or symlink(). Signed-off-by: Toke Høiland-Jørgensen <[email protected]> (cherry picked from commit 092435e) Co-authored-by: Toke Høiland-Jørgensen <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Dec 16, 2019
Commit 6b5b013 ("bpo-26978: Implement pathlib.Path.link_to (Using os.link) (GH-12990)") introduced a new link_to method in pathlib. However, this makes pathlib crash when the 'os' module is missing a 'link' method. Fix this by checking for the presence of the 'link' method on pathlib module import, and if it's not present, turn it into a runtime error like those emitted when there is no lchmod() or symlink(). Signed-off-by: Toke Høiland-Jørgensen <[email protected]> (cherry picked from commit 092435e) Co-authored-by: Toke Høiland-Jørgensen <[email protected]>
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
…17225) Commit 6b5b013 ("bpo-26978: Implement pathlib.Path.link_to (Using os.link) (pythonGH-12990)") introduced a new link_to method in pathlib. However, this makes pathlib crash when the 'os' module is missing a 'link' method. Fix this by checking for the presence of the 'link' method on pathlib module import, and if it's not present, turn it into a runtime error like those emitted when there is no lchmod() or symlink(). Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented
pathlib.Path.link_to.https://bugs.python.org/issue26978