Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-38811: Check for presence of os.link method in pathlib. (GH-17170) #17204

Closed

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 17, 2019

Fix also the Path.symplink() method implementation for the case when
symlinks are not supported.
(cherry picked from commit 111772f)

Co-authored-by: Toke Høiland-Jørgensen [email protected]

https://bugs.python.org/issue38811

…-17170)

Fix also the Path.symplink() method implementation for the case when
symlinks are not supported.
(cherry picked from commit 111772f)

Co-authored-by: Toke Høiland-Jørgensen <[email protected]>
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@tohojo

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@miss-islington
Copy link
Contributor Author

@tohojo and @serhiy-storchaka: Status check is done, and it's a success ✅ .

2 similar comments
@miss-islington
Copy link
Contributor Author

@tohojo and @serhiy-storchaka: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@tohojo and @serhiy-storchaka: Status check is done, and it's a success ✅ .

@vstinner
Copy link
Member

I reject this PR because the change in master broke a buildbot:
#17170 (comment)

@vstinner vstinner closed this Nov 18, 2019
@miss-islington miss-islington deleted the backport-111772f-3.8 branch November 18, 2019 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants