Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45342: Set the ciphers before load_cert_chain #28682

Closed
wants to merge 1 commit into from

Conversation

shreya1312
Copy link

@shreya1312 shreya1312 commented Oct 1, 2021

Example:

self.socket = ssl.wrap_socket(socket.socket(self.address_family, self.socket_type),
                                              keyfile=keys, certfile=certs, server_side=True, ciphers="DEFAULT@SECLEVEL=1")

Gives the following exception -

 File "ssl.py", line 1402, in wrap_socket
    context.load_cert_chain(certfile, keyfile)
ssl.SSLError: [SSL: EE_KEY_TOO_SMALL] ee key too small (_ssl.c:4023)

https://bugs.python.org/issue45342

Example: 
```
self.socket = ssl.wrap_socket(socket.socket(self.address_family, self.socket_type),
                                              keyfile=keys, certfile=certs, server_side=True, ciphers="DEFAULT@SECLEVEL=1")
```
Gives the following exception - 
```
 File "ssl.py", line 1402, in wrap_socket
    context.load_cert_chain(certfile, keyfile)
ssl.SSLError: [SSL: EE_KEY_TOO_SMALL] ee key too small (_ssl.c:4023)
```
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@shreya1312

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@shreya1312 shreya1312 changed the title Set the ciphers before load_cert_chain bpo-45342: Set the ciphers before load_cert_chain Oct 1, 2021
@shreya1312 shreya1312 closed this Oct 1, 2021
@shreya1312 shreya1312 reopened this Oct 1, 2021
@github-actions
Copy link

github-actions bot commented Nov 3, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Nov 3, 2021
@shreya1312
Copy link
Author

Closing this as wrap_socket function was removed in #94203

@shreya1312 shreya1312 closed this Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review stale Stale PR or inactive for long period of time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants