-
-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more FOR_ITER specialization stats #32151
Conversation
How did you choose the categories? What do the stats look like? They look quite tailored to the benchmark suite. Would it possible to generalize them a bit? |
I chose the categories by running the test suite and pyperformance with a |
Ok, we can always change the categories later, if we need to. |
Python/specialize.c
Outdated
@@ -452,6 +452,12 @@ initial_counter_value(void) { | |||
#define SPEC_FAIL_COMPARE_OP_EXTENDED_ARG 24 | |||
|
|||
/* FOR_ITER */ | |||
#define SPEC_FAIL_FOR_ITER_REVERSED 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The values below 8 are common, in the section marked /* Common */
above.
You can always raise SPECIALIZATION_FAILURE_KINDS
if you need.
Results from
I think this is useful information, so I'll go ahead and merge. As was said, we can always adjust things more later. |
No description provided.