Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-47167: Allow overriding a future compliance check in asyncio.Task #32197

Merged
merged 8 commits into from
Apr 1, 2022
Merged

bpo-47167: Allow overriding a future compliance check in asyncio.Task #32197

merged 8 commits into from
Apr 1, 2022

Conversation

asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Mar 30, 2022 •
edited by bedevere-bot
Loading

@asvetlov asvetlov requested a review from 1st1 as a code owner March 30, 2022 15:36
@asvetlov asvetlov added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 31, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @asvetlov for commit da248fc 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 31, 2022
@asvetlov asvetlov merged commit d4bb38f into main Apr 1, 2022
@asvetlov asvetlov deleted the asyncio-task-check branch April 1, 2022 01:25
@1st1
Copy link
Member

1st1 commented Apr 1, 2022

I think this PR should be reverted. I explained why in the issue.

@1st1
Copy link
Member

1st1 commented Apr 1, 2022

@asvetlov Andrew, please don't force commits like this without my review (I'm still listed as a co-owner).

@asvetlov asvetlov mentioned this pull request Apr 10, 2022
Closed
ambv added a commit to ambv/cpython that referenced this pull request Jul 29, 2022
@ambv
Revert "bpo-47167: Allow overriding a future compliance check in asyn…
32ea7d1 
…cio.Task (pythonGH-32197)"

This reverts commit d4bb38f.
ambv added a commit that referenced this pull request Aug 4, 2022
@ambv
gh-91323: Revert "Allow overriding a future compliance check in async…
0342c93 
…io.Task (GH-32197)" (GH-95442)

This reverts commit d4bb38f.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 4, 2022
@ambv @miss-islington
pythongh-91323: Revert "Allow overriding a future compliance check in…
5202170 
… asyncio.Task (pythonGH-32197)" (pythonGH-95442)

This reverts commit d4bb38f.
(cherry picked from commit 0342c93)

Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit that referenced this pull request Aug 4, 2022
@miss-islington @ambv
gh-91323: Revert "Allow overriding a future compliance check in async…
5ac3d0f 
…io.Task (GH-32197)" (GH-95442) (GH-95652)

This reverts commit d4bb38f.
(cherry picked from commit 0342c93)

Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhadthedev arhadthedev arhadthedev left review comments

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asvetlov @bedevere-bot @1st1 @arhadthedev @the-knights-who-say-ni