gh-83004: Clean up refleaks in _decimal initialisation #99043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hauntsaninja
commented
Nov 3, 2022
•
hauntsaninja
commented
- Issue: Improve stdlib module initialization error handling. #83004
hauntsaninja
commented
Nov 3, 2022
| CHECK_INT(PyModule_AddObject(m, "ExtendedContext", | ||
| extended_context_template)); | ||
| CHECK_INT(PyModule_AddObjectRef(m, "ExtendedContext", | ||
| extended_context_template)); | ||
|
|
||
|
|
||
| /* Init mpd_ssize_t constants */ |
There was a problem hiding this comment.
Can't add a comment there because Github, but CHECK_INT(PyModule_AddObject(m, ssize_cm->name, obj)); for obj on L6038 does not leak obj on failure because its reference count is 1 going into PyModule_AddObject and we Py_CLEAR it on goto error inside CHECK_INT.
There was a problem hiding this comment.
Could you update the PR to add a comment about that?
There was a problem hiding this comment.
Ping on this; there's also a merge conflict.
|
Superseded by Serhiy's #106858. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.