Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] gh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (GH-99373) #99493

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

zooba
Copy link
Member

@zooba zooba commented Nov 14, 2022

@zooba zooba changed the title gh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (GH-99373) [3.9] gh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (GH-99373) Nov 14, 2022
@bedevere-bot bedevere-bot added the type-security A security issue label Nov 14, 2022
@zooba
Copy link
Member Author

zooba commented Nov 14, 2022

@pablogsal We agreed (on the original PR) that this is a minor, but harmless change. I'm intending to backport it into my patchset for 3.8 and 3.9 builds at work, so figured that means it's worth backporting for everyone. But your call, of course.

@pablogsal
Copy link
Member

I am +1 backporting this but maybe you want to check with @ambv instead for 3.9 and 3.8?

@pablogsal
Copy link
Member

I am assuming 3.10 has the fix already no?

@zooba
Copy link
Member Author

zooba commented Nov 16, 2022

🤦 Yes, @ambv, what are your thoughts?

It's already in 3.10 in #99492. The backport couldn't be done automatically to 3.9, which is why it's not linked yet

@ambv
Copy link
Contributor

ambv commented Nov 21, 2022

I'm +1 to backport to 3.9 and 3.8.

@ambv ambv merged commit 7b98207 into python:3.9 Nov 21, 2022
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @zooba and @ambv, I had trouble checking out the 3.8 backport branch.
Please retry by removing and re-adding the "needs backport to 3.8" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 7b98207aa46bd637d07a7c4a84e998726b74acde 3.8

@miss-islington
Copy link
Contributor

Thanks @zooba for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@zooba zooba deleted the gh-87604-3.9 branch November 21, 2022 19:05
@bedevere-bot
Copy link

GH-99661 is a backport of this pull request to the 3.8 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-security A security issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants