Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyInstaller: Complete types in build_main.pyi #13528

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

PyInstaller: Complete types in build_main.pyi #13528

wants to merge 2 commits into from
+15 −7

Conversation

Sabfo
Copy link
Contributor

@Sabfo Sabfo commented Feb 23, 2025

Complete the incomplete types of Analysis class constructor params.

@Sabfo
PyInstaller: Complete types in build_main.pyi
f948a4e 
Complete the incomplete types of Analysis class constructor params.
@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

sobolevn
sobolevn requested changes Feb 23, 2025
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add instance attributes to Analysis class, not just __init__ params.

@Sabfo
PyInstaller: Complete types in build_main.pyi
283a92c 
Add annotations for instance attributes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sabfo @sobolevn