Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llama3.2 90b config updates + nits #1950

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

RdoubleA
Copy link
Contributor

@RdoubleA RdoubleA commented Nov 5, 2024

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

Please link to any issues this PR addresses.

Changelog

What are the changes made in this PR?
*

Test plan

Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example

  • I did not change any public API
  • I have added an example to docs or docstrings

Copy link

pytorch-bot bot commented Nov 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1950

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e0b3e7a with merge base 9eced21 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 5, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 25.11%. Comparing base (9eced21) to head (e0b3e7a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
recipes/full_finetune_distributed.py 0.00% 2 Missing ⚠️
recipes/full_finetune_single_device.py 0.00% 2 Missing ⚠️
recipes/lora_finetune_distributed.py 0.00% 2 Missing ⚠️
recipes/lora_finetune_single_device.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1950       +/-   ##
===========================================
- Coverage   68.40%   25.11%   -43.29%     
===========================================
  Files         311      311               
  Lines       16973    16973               
===========================================
- Hits        11610     4263     -7347     
- Misses       5363    12710     +7347     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

log.info(
elif (
self._enable_activation_checkpointing
and cfg.checkpointer.model_type != "LLAMA3_VISION"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if someone tries to use activation offloading with a vision model? broken?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will already error out elsewhere with a descriptive message. but it's odd to see "try activation offloading" and then "activation offloading is not supported for multimodal"

@RdoubleA RdoubleA merged commit 24d3579 into pytorch:main Nov 5, 2024
17 checks passed
@RdoubleA RdoubleA deleted the llama_90b_config branch November 5, 2024 15:27
joecummings pushed a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants