-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llama3.2 90b config updates + nits #1950
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1950
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e0b3e7a with merge base 9eced21 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1950 +/- ##
===========================================
- Coverage 68.40% 25.11% -43.29%
===========================================
Files 311 311
Lines 16973 16973
===========================================
- Hits 11610 4263 -7347
- Misses 5363 12710 +7347 ☔ View full report in Codecov by Sentry. |
log.info( | ||
elif ( | ||
self._enable_activation_checkpointing | ||
and cfg.checkpointer.model_type != "LLAMA3_VISION" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens if someone tries to use activation offloading with a vision model? broken?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will already error out elsewhere with a descriptive message. but it's odd to see "try activation offloading" and then "activation offloading is not supported for multimodal"
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses.
Changelog
What are the changes made in this PR?
*
Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install
)pytest tests
pytest tests -m integration_test
UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example