fix(get): Get completely reworked to function better #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Get method written so that it is used by both cmd/ and api/. Follows the new guideline set out by #519, moving nearly all the logic from lib/ to actions/. Logic which is specific to the command-line, selecting parts of a dataset using a path, moved up a level to the cmd/ package. Get can now be used to retrieve info about local and remote datasets, from both command-line and api server. Fixes #509, #479 #397, and possibly others. Clears the way to merging `body` into `get` in a future PR. Breaks ability to `get` multiple datasets at once.
b5
approved these changes
Aug 23, 2018
| Path: o.Path, | ||
| Format: o.Format, | ||
| Concise: o.Concise, | ||
| // TODO: It is more efficient to only request data in the Path field, but for now |
There was a problem hiding this comment.
Glad this is here. We should def get an RFC going around selectors (querying a dataset), dataset pathing, subsets, and _possibly dataset concatenation.
lib/datasets.go
Outdated
|
|
||
| // Select selects details of one or more datasets | ||
| func (r *DatasetRequests) Select(p *SelectParams, res *[]byte) (err error) { | ||
| // Get a dataset |
There was a problem hiding this comment.
It'd be great if this provided a little more detail:
// Get fetches a dataset head (commit, structure, meta, viz, transform) for a given reference
// The returned *repo.DatasetRef.Dataset field will be populated if a dataset is found
b5
reviewed
Aug 23, 2018
| @@ -12,6 +12,8 @@ import ( | |||
| "github.com/qri-io/qri/repo" | |||
| ) | |||
|
|
|||
| // TODO: Remove this, move other functions to another file, possibly in lib/. | |||
There was a problem hiding this comment.
erm, I think this should stay for now.
This was referenced Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get method written so that it is used by both cmd/ and api/. Follows the new
guideline set out by #519, moving nearly all the logic from lib/ to actions/.
Logic which is specific to the command-line, selecting parts of a dataset
using a path, moved up a level to the cmd/ package.
Get can now be used to retrieve info about local and remote datasets, from
both command-line and api server. Fixes #509, #479 #397, and possibly others.
Clears the way to merging
bodyintogetin a future PR.Breaks ability to
getmultiple datasets at once.