Fix HTML multiline comments bug (#246) (#262)

quantizor · Sep 12, 2019 · 7b55be6 · 7b55be6
1 parent d2d5271
commit 7b55be6
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/index.compiler.spec.js b/index.compiler.spec.js
@@ -1972,6 +1972,21 @@ describe('arbitrary HTML', () => {
   Foo
 </p>
 
+`);
+  });
+
+  it('throws out multiline HTML comments', () => {
+    render(compiler(`Foo\n<!-- this is
+a
+multiline
+comment -->`));
+
+    expect(root.innerHTML).toMatchInlineSnapshot(`
+
+<p data-reactroot>
+  Foo
+</p>
+
 `);
   });
 

diff --git a/index.js b/index.js
@@ -827,6 +827,10 @@ export function compiler(markdown, options) {
       : undefined;
   }
 
+  function stripHtmlComments(html) {
+    return html.replace(/<!--[\s\S]*?(?:-->)/g, '')
+  }
+
   /* istanbul ignore next */
   if (process.env.NODE_ENV !== 'production') {
     if (typeof markdown !== 'string') {
@@ -1552,7 +1556,7 @@ export function compiler(markdown, options) {
   const parser = parserFor(rules);
   const emitter = reactFor(ruleOutput(rules));
 
-  const jsx = compile(markdown);
+  const jsx = compile(stripHtmlComments(markdown));
 
   if (footnotes.length) {
     jsx.props.children.push(

diff --git a/package.json b/package.json
@@ -90,7 +90,7 @@
   "size-limit": [
     {
       "path": "dist/cjs.js",
-      "limit": "5.15 kB"
+      "limit": "5.25 kB"
     }
   ],
   "jest": {