add TLS to infrastructure #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Marcusk19
commented
Sep 29, 2023
Marcusk19
commented
- adds letsencrypt cert to quay_cert.tf
- add ALB to ELB routing
- adds unecessary infrastructure files to .gitignore
- add builder config to deployments with clair enabled
- bounce AWS provider
* adds letsencrypt cert to quay_cert.tf * add ALB to ELB routing * adds unecessary infrastructure files to .gitignore * add builder config to deployments with clair enabled * bounce AWS provider
syed
reviewed
Sep 29, 2023
| @@ -98,4 +95,42 @@ resource "aws_alb_target_group" "quay_alb_metrics_target_group" { | |||
| } | |||
| } | |||
|
|
|||
| /* TODO: Add IPs of ELB automatically to the target group */ | |||
| # Use this to get the resource of the ELB using the tag created by k8s | |||
| data "aws_resourcegroupstaggingapi_resources" "quay_elb" { | |||
There was a problem hiding this comment.
the service is not created until we apply the generated yaml file. So this is a circular dependency
There was a problem hiding this comment.
One solution to this would be to include the kubectl apply in the terraform logic. Having a null_resource dependency with local-exec should allow you to do that
https://developer.hashicorp.com/terraform/language/resources/provisioners/local-exec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.