-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CachyOS support #245
Add CachyOS support #245
Conversation
quickget
Outdated
|
||
validate_release "releases_cachyos" | ||
ISO="cachyos-cli-${RELEASE}-x86_64.iso" | ||
URL="https://deac-fra.dl.sourceforge.net/project/cachyos-arch/cli-installer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will not work: you need to find a way to get and parse a mirror list or provide a static mirror URL so that the script can fetch the iso, ideally also a checksum file. If I run what the web_get() will run here I get redirects and then an error. Also this script us used by a gui so needs to behave consistently for it.
And finally, given the aims of this project to be it would probably be advisable to include the gui-installer version as well as a release option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah there is no api for that yet
but I will try to make one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @philclifford
You can easily get the checksum from https://mirror.cachyos.org/ISO/cachyos-cli-2021.11.10-x86_64.iso
For example: MD5=b944838bfea7ca9058ee599746f003d8d5330de813ce956dea2d9fd0d5a3545a
The next step is to create a router/loadbalancer for the mirros we have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ptr1337 if @vnepogodin updates the PR to set URL to "https://mirror.cachyos.org/ISO/" it would at least work for now. The point of the checksum is for you to make them available (possibly with signature but we currently don't check that ) so that the script can get your ISO and you checksum and compare (because some users ask for this). There is no point whatever in me (or the script) downloading a file, computing a checksum then passing both to a function to see if they check out - I really hope they always will 🙂 ) . So if you add a file (e.g. SHA256Sums ) with a list of checksums and filenames (or one for each file like ${file}.sha512sum) then the script can be made to work. For some supported distros we even have to use a checksum file to find the sum and the filename (as it changes mostly daily at some unknown time...), but that works well and is there in the quickget source to re-use.
THope this helps. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/THope/Hope/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please try to find a better source with an associated checksum file
As per the About section of your webpage, I can see that you, @vnepogodin and @ptr1337, both are involved in the development of CachyOS. Do you have an SVG of the distro's logo, which we could use as an icon for a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that this might sound nit-picky and pedantic, but IMO it is still very important because of the huge amount of lines of code in quickget
:
Please stick to the alphabetical ordering for every change you made in quickget
, this will make it easier to find everything in the big file. Thanks! ;)
Yes I have the logo https://cloud.ptr1337.dev/s/qgmpX5o87si9TND |
Thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installed OK. Thanks for making the requested changes. If a hash file turns up before this is merged or as a future PR so much the better, but this works. Thanks.
Add support for CachyOS