removing old :AMPLITUDE initarg references in qvm-app #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osed to the amplitudes initarg.
sophiaponte
changed the title
…rg when make-instance-ing a pure state qvm.
appleby
reviewed
Dec 10, 2019
jmbr
approved these changes
Dec 10, 2019
There was a problem hiding this comment.
LGTM.
However, I'd like to point out that the use of the generic function and the keyword argument named num-qubits (in the initialize-instances of state-representation.lisp) is inconsistent with the use of number-of-qubits throughout the rest of the qvm. I'd like to have a consistent interface for that at some point.
appleby
approved these changes
Dec 10, 2019
stylewarning
approved these changes
Dec 12, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the qvm state representation refactor,
:AMPLITUDESwas an initarg for the different QVM classes to store the wavefunction data of a qvm. This functionality is now replaced by the QVM'sSTATE, and:AMPLITUDESis no longer a valid initarg for any QVM. This PR changes theQVM-APPto call the:STATEinitarg instead of the:AMPLITUDESinitarg whenmake-instanceing a QVM.This could possibly be more cleanly fixed by having more elegant
make-xxx-qvmfunctions that can take pre-allocated amplitudes as arguments for the different types of QVMs. Since these functions do not exist, the QVM-APP usesmake-instancewhen creating a QVM with an already allocated amplitudes vector.