Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign missing_parameter_annotation to the arg node, not the function node #643

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Assign missing_parameter_annotation to the arg node, not the function node #643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

- Improve the location where `missing_parameter_annotation`
errors are reported (#643)
- Add support for suppressing errors in blocks based on
`sys.platform` and `sys.version_info` checks (#641)
- Fix compatibility between stub-only callable classes
Expand Down
2 changes: 1 addition & 1 deletion pyanalyze/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ def compute_parameters(
idx == 0 and not is_staticmethod and is_nested_in_class
):
ctx.show_error(
node,
arg,
f"Missing type annotation for parameter {arg.arg}",
error_code=ErrorCode.missing_parameter_annotation,
)
Expand Down