Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partial argument match in dbAppendTable #249

Closed
MikeBadescu opened this issue Jun 21, 2018 · 1 comment
Closed

partial argument match in dbAppendTable #249

MikeBadescu opened this issue Jun 21, 2018 · 1 comment

Comments

@MikeBadescu
Copy link

On line 151 in table-insert.R, the name of the argument should be params not param - (dbSendQuery expects param)

DBI/R/table-insert.R

Line 151 in 40a7de4

dbExecute(conn, query, param = unname(as.list(value)))

I believe a similar issue affects RPostgres
https://github.com/r-dbi/RPostgres/blob/7fe22ca9e887ad73f45c9ae3c77991e3725a5c71/R/tables.R#L203

(I discovered this issue while using package strict)
krlmlr added a commit to r-dbi/RPostgres that referenced this issue Aug 26, 2018
@krlmlr
- Fix partial argument matching in dbAppendTable() (r-dbi/DBI#249).
a69e47a
@krlmlr
Copy link
Member

krlmlr commented Aug 26, 2018

Closed in #246.

@krlmlr krlmlr closed this as completed Aug 26, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krlmlr @MikeBadescu