feat: dbQuoteIdentifier() roundtrip is tested for tables only
#256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we cannot get quote-unquote roundtrip to work for schemata, see r-dbi/RPostgres#372
krlmlr
changed the title
dbQuoteIdentifier() roundtrip for tables onlydbQuoteIdentifier() roundtrip is tested for tables only
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the
list_objects_featurestests, so that the quote-unquote roundtrip is applied to tables only, but not for prefix/schemata.We saw in r-dbi/RPostgres#372 that the roundtrip cannot work for schemata alone, since it is not possible to infer from a quoted identifier if it is a table or a schema (or any other DB object for that matter).