-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Replace Rcpp by cpp11 #419
Merged
Merged
Changes from 27 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
93ae2e8
init cpp11
Antonov548 ded1f0d
encrypt.cpp fix
Antonov548 b50174b
connection cpp11::external_pointer
Antonov548 aa71b44
result cpp11::external_pointer
Antonov548 3b6b881
encode.cpp cpp11
Antonov548 88639d1
connection.cpp cpp11
Antonov548 d44c3fe
DbConnection cpp11
Antonov548 6f712d4
update external_pointer release to reset
Antonov548 bfda2ed
Merge branch 'main' into cpp11
krlmlr 6b35f3a
remove error message
Antonov548 39b48f3
update wait_for_notify
Antonov548 a720ae6
return empty list instead of NULL
Antonov548 4c7cf8b
Merge branch 'main' into cpp11
Antonov548 22398b7
result cpp11::list
Antonov548 867b5d3
Merge branch 'cpp11' of https://github.com/Antonov548/RPostgres into …
Antonov548 76ecec5
data frame cpp11
Antonov548 1dc6bde
column storage
Antonov548 e20f8ea
remove strings
Antonov548 ad948f9
warning/stop/package
Antonov548 4db227f
remove Rcpp
Antonov548 ae7a9d4
undo DESCRIPTION
Antonov548 435f97d
fix new line
Antonov548 e60c573
use cpp11 and cpp11 only
pachadotdev 92c27a5
re roxygenize with newer roxygen installed version (7.2.3)
pachadotdev a67c4c2
use std::string for warning/stop
Antonov548 718db2c
Merge pull request #1 from pachadotdev/cpp11
Antonov548 37bc3fe
remove import Rcpp
Antonov548 56de452
update DESCRIPTION
Antonov548 57c7b91
remove cxx11 from Makevars
Antonov548 4b68109
string for cpp11::warning
Antonov548 3a8d2e0
Merge branch 'r-dbi:main' into cpp11
Antonov548 6533d54
Tweak test
krlmlr ac129e5
Merge branch 'main' into cpp11
krlmlr 44c1918
fix: release connection with result
krlmlr 7ca870b
retrun std::string instead of r_string
Antonov548 4a1ac62
Revert "fix: release connection with result"
krlmlr 87def43
Early return if connection closed already
krlmlr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,3 +26,4 @@ windows | |
^\.gitpod\.yml$ | ||
^\.gitpod\.Dockerfile$ | ||
^CMakeLists\.txt$ | ||
^vscode-install\.r$ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -1,6 +1,6 @@ | ||||||||||||
Package: RPostgres | ||||||||||||
Title: Rcpp Interface to PostgreSQL | ||||||||||||
Version: 1.4.5.9002 | ||||||||||||
Version: 1.4.5.9003 | ||||||||||||
Date: 2023-01-24 | ||||||||||||
Authors@R: c( | ||||||||||||
person("Hadley", "Wickham", role = "aut"), | ||||||||||||
|
@@ -26,7 +26,6 @@ Imports: | |||||||||||
hms (>= 1.0.0), | ||||||||||||
lubridate, | ||||||||||||
methods, | ||||||||||||
Rcpp (>= 1.0.7), | ||||||||||||
withr | ||||||||||||
Suggests: | ||||||||||||
callr, | ||||||||||||
|
@@ -36,8 +35,8 @@ Suggests: | |||||||||||
rmarkdown, | ||||||||||||
testthat (>= 3.0.0) | ||||||||||||
LinkingTo: | ||||||||||||
plogr (>= 0.2.0), | ||||||||||||
Rcpp | ||||||||||||
cpp11, | ||||||||||||
plogr (>= 0.2.0) | ||||||||||||
VignetteBuilder: | ||||||||||||
knitr | ||||||||||||
Config/autostyle/scope: line_breaks | ||||||||||||
|
@@ -47,15 +46,16 @@ Encoding: UTF-8 | |||||||||||
LazyLoad: true | ||||||||||||
Roxygen: list(markdown = TRUE) | ||||||||||||
RoxygenNote: 7.2.3 | ||||||||||||
SystemRequirements: libpq >= 9.0: libpq-dev (deb) or postgresql-devel | ||||||||||||
(rpm) | ||||||||||||
SystemRequirements: | ||||||||||||
libpq >= 9.0: libpq-dev (deb) or postgresql-devel (rpm), | ||||||||||||
C++11 | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. C++11 can no longer be mentioned due to recent changes in R-devel. Will the checks succeed if we leave it out?
Suggested change
|
||||||||||||
Collate: | ||||||||||||
'PqDriver.R' | ||||||||||||
'PqConnection.R' | ||||||||||||
'PqResult.R' | ||||||||||||
'RPostgres-pkg.R' | ||||||||||||
'RcppExports.R' | ||||||||||||
'Redshift.R' | ||||||||||||
'cpp11.R' | ||||||||||||
'dbAppendTable_PqConnection.R' | ||||||||||||
'dbBegin_PqConnection.R' | ||||||||||||
'dbBind_PqResult.R' | ||||||||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,105 @@ | ||
# Generated by cpp11: do not edit by hand | ||
|
||
client_version <- function() { | ||
.Call(`_RPostgres_client_version`) | ||
} | ||
|
||
connection_create <- function(keys, values, check_interrupts) { | ||
.Call(`_RPostgres_connection_create`, keys, values, check_interrupts) | ||
} | ||
|
||
connection_valid <- function(con_) { | ||
.Call(`_RPostgres_connection_valid`, con_) | ||
} | ||
|
||
connection_release <- function(con_) { | ||
invisible(.Call(`_RPostgres_connection_release`, con_)) | ||
} | ||
|
||
connection_info <- function(con) { | ||
.Call(`_RPostgres_connection_info`, con) | ||
} | ||
|
||
connection_quote_string <- function(con, xs) { | ||
.Call(`_RPostgres_connection_quote_string`, con, xs) | ||
} | ||
|
||
connection_quote_identifier <- function(con, xs) { | ||
.Call(`_RPostgres_connection_quote_identifier`, con, xs) | ||
} | ||
|
||
connection_is_transacting <- function(con) { | ||
.Call(`_RPostgres_connection_is_transacting`, con) | ||
} | ||
|
||
connection_set_transacting <- function(con, transacting) { | ||
invisible(.Call(`_RPostgres_connection_set_transacting`, con, transacting)) | ||
} | ||
|
||
connection_copy_data <- function(con, sql, df) { | ||
invisible(.Call(`_RPostgres_connection_copy_data`, con, sql, df)) | ||
} | ||
|
||
connection_wait_for_notify <- function(con, timeout_secs) { | ||
.Call(`_RPostgres_connection_wait_for_notify`, con, timeout_secs) | ||
} | ||
|
||
connection_get_temp_schema <- function(con) { | ||
.Call(`_RPostgres_connection_get_temp_schema`, con) | ||
} | ||
|
||
connection_set_temp_schema <- function(con, temp_schema) { | ||
invisible(.Call(`_RPostgres_connection_set_temp_schema`, con, temp_schema)) | ||
} | ||
|
||
encode_vector <- function(x) { | ||
.Call(`_RPostgres_encode_vector`, x) | ||
} | ||
|
||
encode_data_frame <- function(x) { | ||
.Call(`_RPostgres_encode_data_frame`, x) | ||
} | ||
|
||
encrypt_password <- function(password, user) { | ||
.Call(`_RPostgres_encrypt_password`, password, user) | ||
} | ||
|
||
init_logging <- function(log_level) { | ||
invisible(.Call(`_RPostgres_init_logging`, log_level)) | ||
} | ||
|
||
result_create <- function(con, sql, immediate) { | ||
.Call(`_RPostgres_result_create`, con, sql, immediate) | ||
} | ||
|
||
result_release <- function(res) { | ||
invisible(.Call(`_RPostgres_result_release`, res)) | ||
} | ||
|
||
result_valid <- function(res_) { | ||
.Call(`_RPostgres_result_valid`, res_) | ||
} | ||
|
||
result_fetch <- function(res, n) { | ||
.Call(`_RPostgres_result_fetch`, res, n) | ||
} | ||
|
||
result_bind <- function(res, params) { | ||
invisible(.Call(`_RPostgres_result_bind`, res, params)) | ||
} | ||
|
||
result_has_completed <- function(res) { | ||
.Call(`_RPostgres_result_has_completed`, res) | ||
} | ||
|
||
result_rows_fetched <- function(res) { | ||
.Call(`_RPostgres_result_rows_fetched`, res) | ||
} | ||
|
||
result_rows_affected <- function(res) { | ||
.Call(`_RPostgres_result_rows_affected`, res) | ||
} | ||
|
||
result_column_info <- function(res) { | ||
.Call(`_RPostgres_result_column_info`, res) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't change this in PRs.