Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider putting the precious list in the package namespace rather than a global option. #151

Closed
jimhester opened this issue Mar 16, 2021 · 1 comment
Labels
feature a feature request or enhancement

Comments

@jimhester
Copy link
Member

This would potentially allow easier debugging when tracking down memory issues.

Basically you would need to add a call to a function in .onLoad() that initializes the precious list for that package.

For rmarkdown use cases we would use the cpp11 namespace to hold the list.

@jimhester jimhester added the feature a feature request or enhancement label Mar 31, 2021
@DavisVaughan
Copy link
Member

#331 moved us towards one preserve list per compilation unit, and removed our reliance on a global option, which had caused issues over the years (in particular, if we ever change the structure of it, we can completely bork anyone who vendored cpp11 and still used the old structure)

#364 moves us towards one preserve list per package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants