Create 1 preserve list per compilation unit #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
On further thought I think it'd still be nicer to store in the calling package's namespace. Not only for graph-domination purposes but also it'd make it possible to add some R-level tools in cpp11 to inspect all objects currently created by your cpp11 code, which might be useful in debugging situations.
It shouldn't be too hard to do that once we've added a symbol in the init file that represents the package namespace. This will make it possible to grab the namespace environment to get the precious list in the first run. And the init list could be initialised from the C-level init function.
Not a blocker by any means, this PR is already good for now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #330 (see this issue for full discussion)
Closes #268 (as there is no longer a global option)
This is the minimal amount of work to move from a global protection list to 1 protection list per compilation unit.
In two follow up PRs I will:
release_all(), require R >= 3.5.0, removeCPP11_USE_PRESERVE_OBJECTand its related code (not much), remove the documentation section about R 3.5.0 and the tradeoffs about unwind-protect (Require R >=3.5.0 and removerelease_all()#332)