Update GitHub Actions workflows, and make necessary tweaks to support them #279
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,14 @@ | ||
| # Workflow derived from https://github.com/r-lib/actions/tree/v2/examples | ||
| # Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help | ||
| # | ||
| # NOTE: This workflow is overkill for most R packages and | ||
| # check-standard.yaml is likely a better choice. | ||
| # usethis::use_github_action("check-standard") will install it. | ||
| on: | ||
| push: | ||
| branches: [main, master] | ||
| pull_request: | ||
| branches: [main, master] | ||
|
|
||
| name: R-CMD-check | ||
|
|
||
|
|
@@ -27,92 +23,74 @@ jobs: | |
| matrix: | ||
| config: | ||
| - {os: macOS-latest, r: 'release'} | ||
|
|
||
| - {os: windows-latest, r: 'release'} | ||
| # Use 3.6 to trigger usage of RTools35 | ||
| - {os: windows-latest, r: '3.6'} | ||
|
|
||
| # Use older ubuntu to maximise backward compatibility | ||
| - {os: ubuntu-20.04, r: 'devel', http-user-agent: 'release'} | ||
DavisVaughan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - {os: ubuntu-20.04, r: 'release'} | ||
| - {os: ubuntu-20.04, r: 'release', custom: 'no-cpp11test'} | ||
| - {os: ubuntu-20.04, r: 'release', custom: 'gcc 4.8'} | ||
| - {os: ubuntu-20.04, r: 'oldrel-1'} | ||
| - {os: ubuntu-20.04, r: 'oldrel-2'} | ||
| - {os: ubuntu-20.04, r: 'oldrel-3'} | ||
| - {os: ubuntu-20.04, r: 'oldrel-4'} | ||
|
|
||
| env: | ||
| GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }} | ||
| R_KEEP_PKG_SOURCE: yes | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - uses: r-lib/actions/setup-pandoc@v2 | ||
|
|
||
| - uses: r-lib/actions/setup-r@v2 | ||
| with: | ||
| r-version: ${{ matrix.config.r }} | ||
| http-user-agent: ${{ matrix.config.http-user-agent }} | ||
| use-public-rspm: true | ||
|
|
||
| - name : Install compiler version | ||
| # We check on this old compiler specifically to support CentOS 7, | ||
| # which uses this gcc version. RStudio products support CentOS 7 through | ||
| # June 2024. | ||
| # https://github.com/r-lib/cpp11/pull/78 | ||
| # https://www.rstudio.com/about/platform-support/ | ||
| # Ubuntu 20.04 technically dropped support for gcc 4.8, so we have to | ||
| # add old archives back in manually to install it | ||
| # https://github.com/r-lib/cpp11/pull/279 | ||
| if: matrix.config.custom == 'gcc 4.8' | ||
| run: | | ||
| echo "deb http://dk.archive.ubuntu.com/ubuntu/ xenial main" | sudo tee -a /etc/apt/sources.list | ||
| echo "deb http://dk.archive.ubuntu.com/ubuntu/ xenial universe" | sudo tee -a /etc/apt/sources.list | ||
| sudo apt update | ||
|
Comment on lines
+57
to
+69
There was a problem hiding this comment. I have retained support for testing gcc 4.8, but it wasn't easy. The move to Ubuntu 20.04 means that The way to fix this is to add older archives into the Corresponds to this commit 6a2994a There was a problem hiding this comment. Calling out the fact that RStudio are doing this to support CentOS7, I wonder if it would make sense to move to using docker for CentOS 7 explicitly, in order to better replicate the environment you are trying to support, IIRC you would have to use Docker for everything then, so maybe not worth it, or you could run this in a separate workflow... There was a problem hiding this comment. I opened #281 to consider this Arrow uses a docker image in this way, so we could probably do the same |
||
| sudo apt-get install -y g++-4.8 | ||
| mkdir ~/.R/ | ||
| echo $'CXX1X=g++-4.8\nCXX11=g++-4.8\nCC=gcc-4.8' >> ~/.R/Makevars | ||
|
There was a problem hiding this comment. The addition of Some research turned up that this flag was only supported in gcc >=4.9, so gcc is right that it shouldn't be there. It turns out this flag was being added by pkgbuild during It gets added if it looks like the compiler supports colored diagnostics, i.e. the So my fix for this is to just force the C compiler to also be gcc 4.8 so this helper returns Reported to pkgbuild here r-lib/pkgbuild#141 Corresponds to this commit f59c833 There was a problem hiding this comment. yeah, that sounds right, I wonder if pkgbuild should test both the CC and CXX points. Alternatively perhaps it is better practice to use the same toolchain for C and C++ anyway (even though there is no C code being compiled here) There was a problem hiding this comment.
Gabor and I are talking about exactly that in r-lib/pkgbuild#141 |
||
|
|
||
| - name: Install macOS system dependencies | ||
| if: runner.os == 'macOS' | ||
| run: brew install --cask xquartz | ||
|
|
||
| - uses: r-lib/actions/setup-r-dependencies@v2 | ||
| with: | ||
| extra-packages: any::rcmdcheck | ||
| needs: check | ||
|
|
||
| - name: Install cpp11test | ||
| if: matrix.config.custom != 'no-cpp11test' | ||
| run: | | ||
| options(warn = 2) | ||
| pak::local_install_dev_deps("cpp11test", dependencies = TRUE) | ||
| install.packages("cpp11test", repos = NULL, INSTALL_opts = "--install-tests", type = "source") | ||
| shell: Rscript {0} | ||
|
|
||
| - uses: r-lib/actions/check-r-package@v2 | ||
| with: | ||
| upload-snapshots: true | ||
|
|
||
| - name: Run cpp11test tests | ||
| if: matrix.config.custom != 'no-cpp11test' | ||
|
|
@@ -122,20 +100,3 @@ jobs: | |
| library(cpp11test) | ||
| test_check("cpp11test", reporter = "progress") | ||
| shell: Rscript {0} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ name: format_check | |
|
|
||
| jobs: | ||
| format_check: | ||
| runs-on: ubuntu-20.04 | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,35 +1,48 @@ | ||
| # Workflow derived from https://github.com/r-lib/actions/tree/v2/examples | ||
| # Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help | ||
| on: | ||
| push: | ||
| branches: [main, master] | ||
| pull_request: | ||
| branches: [main, master] | ||
| release: | ||
| types: [published] | ||
| workflow_dispatch: | ||
|
|
||
| name: pkgdown | ||
|
|
||
| jobs: | ||
| pkgdown: | ||
| runs-on: ubuntu-latest | ||
| # Only restrict concurrency for non-PR jobs | ||
| concurrency: | ||
| group: pkgdown-${{ github.event_name != 'pull_request' || github.run_id }} | ||
| env: | ||
| GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }} | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - uses: r-lib/actions/setup-pandoc@v2 | ||
|
|
||
| - uses: r-lib/actions/setup-r@v2 | ||
| with: | ||
| use-public-rspm: true | ||
|
|
||
| - uses: r-lib/actions/setup-r-dependencies@v2 | ||
| with: | ||
| extra-packages: any::pkgdown, local::., local::cpp11test | ||
|
Comment on lines
-26
to
+33
There was a problem hiding this comment. Retained installation of cpp11test here |
||
| needs: website | ||
|
|
||
| - name: Build site | ||
| env: | ||
| CPP11_EVAL: true | ||
|
There was a problem hiding this comment. In particular, made sure to retain this! |
||
| run: pkgdown::build_site_github_pages(new_process = FALSE, install = FALSE) | ||
| shell: Rscript {0} | ||
|
|
||
| - name: Deploy to GitHub pages 🚀 | ||
| if: github.event_name != 'pull_request' | ||
| uses: JamesIves/[email protected] | ||
| with: | ||
| clean: false | ||
| branch: gh-pages | ||
| folder: docs | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,55 +1,79 @@ | ||
| # Workflow derived from https://github.com/r-lib/actions/tree/v2/examples | ||
| # Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help | ||
| on: | ||
| issue_comment: | ||
| types: [created] | ||
|
|
||
| name: Commands | ||
|
|
||
| jobs: | ||
| document: | ||
| if: ${{ github.event.issue.pull_request && (github.event.comment.author_association == 'MEMBER' || github.event.comment.author_association == 'OWNER') && startsWith(github.event.comment.body, '/document') }} | ||
| name: document | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }} | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - uses: r-lib/actions/pr-fetch@v2 | ||
| with: | ||
| repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - uses: r-lib/actions/setup-r@v2 | ||
| with: | ||
| use-public-rspm: true | ||
|
|
||
| - uses: r-lib/actions/setup-r-dependencies@v2 | ||
| with: | ||
| extra-packages: any::roxygen2 | ||
| needs: pr-document | ||
|
|
||
| - name: Document | ||
| run: roxygen2::roxygenise() | ||
| shell: Rscript {0} | ||
|
|
||
| - name: commit | ||
| run: | | ||
| git config --local user.name "$GITHUB_ACTOR" | ||
| git config --local user.email "[email protected]" | ||
| git add man/\* NAMESPACE | ||
| git commit -m 'Document' | ||
|
|
||
| - uses: r-lib/actions/pr-push@v2 | ||
| with: | ||
| repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| style: | ||
| if: ${{ github.event.issue.pull_request && (github.event.comment.author_association == 'MEMBER' || github.event.comment.author_association == 'OWNER') && startsWith(github.event.comment.body, '/style') }} | ||
| name: style | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }} | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - uses: r-lib/actions/pr-fetch@v2 | ||
| with: | ||
| repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - uses: r-lib/actions/setup-r@v2 | ||
|
|
||
| - name: Install dependencies | ||
| run: install.packages("styler") | ||
| shell: Rscript {0} | ||
|
|
||
| - name: Style | ||
| run: styler::style_pkg() | ||
| shell: Rscript {0} | ||
|
|
||
| - name: commit | ||
| run: | | ||
| git config --local user.name "$GITHUB_ACTOR" | ||
| git config --local user.email "[email protected]" | ||
| git add \*.R | ||
| git commit -m 'Style' | ||
|
|
||
| - uses: r-lib/actions/pr-push@v2 | ||
| with: | ||
| repo-token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub Actions is no longer supporting Ubuntu 18.04, so we switched to 20.04.
Note that r-lib/actions actually just switched to
ubuntu-latestas the default, but I think for cpp11 it is worth trying to continue to test on "older" Ubuntu versions like 20.04 r-lib/actions#612