Improve performance (#172)

Part of #167

NEWS.md

@@ -1,5 +1,9 @@
 # lifecycle (development version)
 
+* Switch from `expr_deparse()` to `deparse()`. This improves performance
+  considerably and the cost of making some unusual function calls mildly 
+  less appealing (#167).
+
 # lifecycle 1.0.3
 
 * The `with` line is now an info bullet. The `details` lines are info

R/spec.R

@@ -73,7 +73,7 @@ spec_fn <- function(call, ctxt) {
   }
 
   # Deparse so non-syntactic names are backticked
-  expr_deparse(fn)
+  deparse(fn)
 }
 
 spec_arg <- function(call, ctxt) {
@@ -118,7 +118,7 @@ spec_reason <- function(call, ctxt) {
     return(node_car(arg))
   }
 
-  fn <- expr_deparse(node_car(call))
+  fn <- deparse(node_car(call))
   cli::cli_abort(
     c(
       "{.arg what} must contain reason as a string on the RHS of `=`.",

tests/testthat/_snaps/deprecate.md

@@ -122,15 +122,15 @@
     Code
       cat_line(lifecycle_message("1.0.0", "`foo-fy`(`qu-ux` = )"))
     Output
-      The `qu-ux` argument of `foo-fy` is deprecated as of base 1.0.0.
+      The `qu-ux` argument of `foo-fy()` is deprecated as of base 1.0.0.
     Code
       cat_line(lifecycle_message("1.0.0", "`foo<-`()"))
     Output
-      `foo<-` was deprecated in base 1.0.0.
+      `foo<-()` was deprecated in base 1.0.0.
     Code
       cat_line(lifecycle_message("1.0.0", "`+`()"))
     Output
-      `+` was deprecated in base 1.0.0.
+      `+()` was deprecated in base 1.0.0.
 
 # details uses an info bullet by default