Added responsive styles for grid-area
#569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
hey @vladmoroz, sorry to bug you, but do you think this is ok to be merged soon? Also happy to make changes if you'd like to see this set up differently. Thanks! |
|
Hey @benmarch, I'm catching up on some old PRs and I'd like to merge this for the next release. Do you mind adding a changelog entry for 3.1.5 and add a short bullet? |
|
All set! Thanks, @chaance, much appreciated! |
chaance
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The documentation for the
gridArealayout prop indicates that it is responsive, but I noticed that the responsive styles were not working for me. This adds the classes needed to make thegridAreaprop responsive.Testing steps
I added an additional example to the grid-area playground example that uses responsive values for
grid-area. These specific values ensure that the responsive styles work correctly because without the styles, theCard's body text only spans a single column.Relates issues / PRs