Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agregar test #37

Open
raicerk opened this issue Oct 24, 2020 · 4 comments
Open

Agregar test #37

raicerk opened this issue Oct 24, 2020 · 4 comments
Labels
enhancement New feature or request hacktoberfest hacktoberfest

Comments

@raicerk
Copy link
Owner

raicerk commented Oct 24, 2020

Hay que agregar test, idealmente usando la libreria de test de jest
@raicerk raicerk added enhancement New feature or request hacktoberfest hacktoberfest labels Oct 24, 2020
eLeontev added a commit to eLeontev/Chart-Tech-Trends that referenced this issue Oct 25, 2020
@eLeontev
raicerk#37 add tests for #cantidadOfertas with using Jest
bc3c559
@eLeontev eLeontev mentioned this issue Oct 25, 2020
Merged
@eLeontev
Copy link
Contributor

eLeontev commented Oct 25, 2020 •
edited
Loading

I've added tests for api.cantidadOfertas method.

Run npm run test uses Jest under the hood, so implemented test is written follow Jest syntax.

If my PR is good to merge I can continue to add tests for at least api.js

P.s. I'd used translator from Spanish to define the task and I hope I got the point.

@eLeontev
Copy link
Contributor

@raicerk hi can you review the PR?

@raicerk
Copy link
Owner Author

raicerk commented Oct 28, 2020

@eLeontev I like it! I need define more test for all case, but your apoc is perfect

@raicerk raicerk closed this as completed Oct 28, 2020
@raicerk raicerk reopened this Oct 28, 2020
raicerk pushed a commit that referenced this issue Oct 28, 2020
@eLeontev
#37 add tests for #cantidadOfertas with using Jest (#40)
a00ea17
@raicerk
Copy link
Owner Author

raicerk commented Oct 28, 2020

@eLeontev this issue will remain open for add and linking other test (PRs)

raicerk added a commit that referenced this issue Oct 25, 2021
@joseglego @raicerk @eLeontev
Update Develop (#46)
87815ed 
* change chart bar to horizontal bar for mobile view (#41)

* Update pull_request_template.md

* Feat/handle errors (#39)

* feat(CommonSection): show only the section with information

* feat(RelatedSkill): show section ONLY if has data

* feat(Section): show section ONLY if has data

* feat(error): show error message

* #37 add tests for #cantidadOfertas with using Jest (#40)

* core(pr_template): update style in PR template (#50)

* core(node-version): stablis node12 as engine because error with node16 (#49)

* Feat/get country (#48)

* feat(api): define Api.pais to get current country

* feat(App): getApiCountry if it is not provided by url

* Feat/show loading (#47)

* feat(Loading): define loading spinner

* feat(Section): show LoadingSpinner while Loading

Co-authored-by: Juan Mora <[email protected]>
Co-authored-by: eLeontev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raicerk @eLeontev