Support non-contiguous functions #71
Conversation
There was a problem hiding this comment.
Thanks for your contribution and sorry for the delay.
LGTM, though I don't have the expertise to actually judge.
Can you add a test similar to the existing few: https://github.com/rainers/cv2pdb/blob/master/.github/workflows/build-and-test.yml#L44
| @@ -34,7 +34,7 @@ | |||
| <Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" /> | |||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'" Label="Configuration"> | |||
| <ConfigurationType>Application</ConfigurationType> | |||
| <PlatformToolset>v120_xp</PlatformToolset> | |||
| <PlatformToolset>$(DefaultPlatformToolset)</PlatformToolset> | |||
There was a problem hiding this comment.
I don't think this works in VS2017, that is still used by the Appveyor build of Visual D that includes cv2pdb. Can you add defaulting DefaultPlatformToolset to v120_xp if it is not yet set?
There was a problem hiding this comment.
The reason I changed this is because the program no longer compiles with the v120 tools, since those don't support constexpr
There was a problem hiding this comment.
Hmm, this is supposed to work according to #69 (comment) , maybe depends on the exact version of the compiler.
It builds on appveyor with cl 14.16.27023: https://ci.appveyor.com/project/rainers/visuald/builds/42205296
Adding something like
<DefaultPlatformToolset Condition="'$(DefaultPlatformToolset)' == ''">v120_xp</DefaultPlatformToolset>
to the property group a couple of lines above should do the trick to use the default on newer VS versions.
There was a problem hiding this comment.
It builds because the Makefile explicitly overrides PlatformToolset to v141, which is Visual Studio 2017: https://github.com/dlang/visuald/blob/9c90ff0e9f1e93962324486375426892665926d9/Makefile#L170
v120 is Visual Studio 2013, which doesn't support constexpr, and was disabled in 2019: dlang/visuald@15216ca
There was a problem hiding this comment.
Oops, indeed. Sorry for the noise. So yes. let's get rid of v120_xp.
Marc-Aldorasi-Imprivata
force-pushed
the
non-contiguous-functions
branch
from
d720057 to
c68f6fe
Compare
Marc-Aldorasi-Imprivata
force-pushed
the
non-contiguous-functions
branch
from
c68f6fe to
4b53f1e
Compare
|
Thanks and sorry for the delay, somehow fell off the radar. |
This changes
CV2PDB::addDWARFProcto take a sequence of address ranges. The first address range (which starts at the function entry point) still emits aS_GPROC_V3block, but the additional ranges emitS_SEPCODE_V3blocks which reference theS_GPROC_V3block, so when the debugger displays an address in one of these ranges it will display ascorrect_function_name+large_offset_from_entry_addressinstead ofunrelated_symbol+small_offset.This fixes issue #52.