Provide explicit pool size and avoid RMM detail APIs #14741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
added
improvement
ttnghia
reviewed
Jan 11, 2024
| @@ -33,7 +34,8 @@ inline auto make_pool_instance() | |||
| { | |||
| static rmm::mr::cuda_memory_resource cuda_mr; | |||
| static auto pool_mr = | |||
| std::make_shared<rmm::mr::pool_memory_resource<rmm::mr::cuda_memory_resource>>(&cuda_mr); | |||
| std::make_shared<rmm::mr::pool_memory_resource<rmm::mr::cuda_memory_resource>>( | |||
| &cuda_mr, rmm::percent_of_free_device_memory(50)); | |||
There was a problem hiding this comment.
I'm thinking about whether we should parse percent_of_free_device_memory from some env variable, instead of hard coding like this in many places. By doing so we can control the number we want at runtime.
There was a problem hiding this comment.
This PR is just fixing cuDF so that it has the same behavior, and doesn't break when I merge upcoming deprecation PRs. I will file a cuDF issue for this request, but I think the cuDF team should handle it.
ttnghia
reviewed
Jan 15, 2024
ttnghia
approved these changes
Jan 15, 2024
3 tasks
|
/merge |
|
Thanks for the reviews @ttnghia @PointKernel |
rapids-bot bot
pushed a commit
to rapidsai/rmm
that referenced
this pull request
Jan 17, 2024
…ilities, and optional pool_memory_resource initial size (#1424) Follow-on to #1417, this PR deprecates the following: - `rmm::detail::available_device_memory` in favor of rmm::available_device_memory - `rmm::detail::is_aligned`, `rmm::detail::align_up` and related alignment utility functions in favor of the `rmm::` top level namespace versions. - The `rmm::pool_memory_resource` constructors that take an optional initial size parameter. Should be merged after the following: - rapidsai/cugraph#4086 - rapidsai/cudf#14741 - rapidsai/raft#2088 Authors: - Mark Harris (https://github.com/harrism) Approvers: - Michael Schellenberger Costa (https://github.com/miscco) - Rong Ou (https://github.com/rongou) URL: #1424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes up cuDF to avoid usage that will soon be deprecated in RMM.
Depends on rapidsai/rmm#1417
Fixes #14658