Feature 4/h captcha support with auth pages #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MuhammadUsama-hub
requested changes
Feb 25, 2025
There was a problem hiding this comment.
use kebab case for file naming
| import { MailOutlined } from "@ant-design/icons"; | ||
| import HCaptcha from "@hcaptcha/react-hcaptcha"; | ||
|
|
||
| type FormValues = { |
There was a problem hiding this comment.
move this in auth module types and export it to be use where its need
|
|
||
| return ( | ||
| <div> | ||
| <Form<FormValues> onFinish={onFinish}> |
There was a problem hiding this comment.
why using this <FormValues> tag inside <Form> tag?
| import React from "react"; | ||
| import { useParams } from "react-router-dom"; | ||
|
|
||
| type FormValues = { |
There was a problem hiding this comment.
this also move in to auth module types
|
|
||
| return ( | ||
| <div> | ||
| <Form<FormValues> onFinish={onFinish} layout="vertical"> |
There was a problem hiding this comment.
same here using <FormValues> tag as above
| <Form.Item | ||
| name="otp" | ||
| label="Otp" | ||
| rules={[{ required: true, message: "Please enter a password" }]} |
There was a problem hiding this comment.
correct message as it for otp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4