feat(Dropdown): add E2E tests #1962
Conversation
saurabhdaware
requested review from
chaitanyadeorukhkar and
kamleshchandnani
as code owners
🦋 Changeset detectedLatest commit: be7c691 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✅ PR title follows Conventional Commits specification. |
| useDidUpdate(() => { | ||
| onOpenChange?.(isOpen); | ||
| if (!isOpen) { |
There was a problem hiding this comment.
With this logic, we were calling onOpenChange as well as we were actually closing and opening dropdown.
Ideally we should only call onOpenChange wherever state needs to change and then consumers add
<Dropdown isOpen={isDropdownOpen} onOpenChange={(isOpen) => { setIsDropdownOpen(isOpen) }} />if someone doesn't call state change in onOpenChange, then it shouldn't close the dropdown.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| const setIsOpenControlled = (isControlledStateOpen: boolean): void => { | ||
| onOpenChange?.(isControlledStateOpen); | ||
| if (!isControlledStateOpen) { |
There was a problem hiding this comment.
Can we use the useControllableState hook to manage the controlled/uncontrolled behaviour of isOpen?
There was a problem hiding this comment.
ouu didn't know about this hook. let me see.
done |
chaitanyadeorukhkar
added
Run Interaction Tests
and removed
Run Interaction Tests
labels
* feat: add initial dropdown test * feat: move major interaction tests to e2e * feat: add controleld dropdown e2e tests * Create lovely-chairs-sneeze.md * fix: console log * Update lovely-chairs-sneeze.md * Update lovely-chairs-sneeze.md * fix: BaseInput 2 clicks on dropdown * fix: test for safari * fix: handle double clicks with stopPropogation * fix: eslint error * fix: lint
onOpenChange