Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

feat: moving local development up to npm@7 #1318

Merged
merged 20 commits into from
Jun 11, 2021
Merged

feat: moving local development up to npm@7 #1318

merged 20 commits into from
Jun 11, 2021

Conversation

erunion
Copy link
Member

@erunion erunion commented Jun 10, 2021

☁️   CI App

🧰 What's being changed?

  • Moves all local development and package.json files over to npm@7
  • Updates internal package pointers to use file:../<package name>
    • Unclear how this'll actually interact with NPM when the package is published but hey it works locally so it might work?
  • Fixed a minor bug in our api-logs package where our PHP SDK was being improperly named as "Php".

🧬 Testing

  • Tests pass?
  • Server run still?

@erunion erunion added type:bug Something isn't working type:enhancement A potential new feature to be added, or an improvement we could make labels Jun 10, 2021
@erunion erunion requested a deployment to explorer-pr-1318 June 10, 2021 22:16 Abandoned
@erunion erunion temporarily deployed to explorer-pr-1318 June 10, 2021 22:18 Inactive
@erunion erunion temporarily deployed to explorer-pr-1318 June 10, 2021 22:25 Inactive
@erunion erunion temporarily deployed to explorer-pr-1318 June 10, 2021 22:36 Inactive
@erunion erunion temporarily deployed to explorer-pr-1318 June 10, 2021 22:51 Inactive
@erunion erunion temporarily deployed to explorer-pr-1318 June 10, 2021 23:12 Inactive
@erunion erunion temporarily deployed to explorer-pr-1318 June 10, 2021 23:25 Inactive
@erunion erunion temporarily deployed to explorer-pr-1318 June 10, 2021 23:30 Inactive
@erunion erunion temporarily deployed to explorer-pr-1318 June 11, 2021 00:00 Inactive
@erunion erunion requested review from ilias-t and Dashron June 11, 2021 00:00
Copy link
Contributor

@Dashron Dashron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

environment seems to be working fine, and nothing jumps out at me in the code!

@erunion erunion merged commit 7738bb8 into main Jun 11, 2021
@erunion erunion deleted the feat/npm7 branch June 11, 2021 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:bug Something isn't working type:enhancement A potential new feature to be added, or an improvement we could make
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants