-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add back padding to lists in callouts #126
Conversation
CX-16 Broken Numbered List in Callouts
Taboola getting frustrated that we haven't fixed a few issues in our callouts when the new markdown engine is enabled. It's been over a year since they reported this.
I've suggested a couple of workarounds that have been completely rejected. Workarounds are not acceptable in this situation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice; I have one stylistic suggestion below but this is pretty much good. Tangentially, I also noticed some oddities with our demo app:
When you try to edit the markdown syntax, each keystroke blurs the editor text area, and makes it a bit of a headache to run a quick syntax test.- We're pulling ReadMe's
bundle-hub2.css
in to the demo apps to better mimic prod. But since that file includes RDMD's current CSS, it can cause some accidental overrides/underrides, and just generally make it kind of hard to test new style changes.
We don't have to address these issues immediately in this PR, just thought I should write 'em down before I forgot!
Yea, I noticed that too. 😬 Should be fixed in the 2nd commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 Lookin' good; and thanks for fixing up that focus issue!
Ok, not a complete fix, but I imported the local styles into the demo app, so they should override the hubs styling. |
This PR was released!🚀 Changes included in v6.25.3-next.1 |
This PR was released!🚀 Changes included in v6.26.0 |
🧰 Changes
🧬 QA & Testing