Skip to content

Commit

Permalink
[SYCL] Clean-up lazy queue PI changes
Browse files Browse the repository at this point in the history
* PI Minor version bump for new flag
* Document new PI property as comments
* Make value next consecutive bit `1 << 5`, rather
  than `1 << 11`.
  • Loading branch information
EwanC committed Dec 2, 2022
1 parent 7bb11ce commit 3073cfc
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
12 changes: 10 additions & 2 deletions sycl/include/sycl/detail/pi.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,10 @@
// 10.13 Added new PI_EXT_ONEAPI_QUEUE_DISCARD_EVENTS queue property.
// 10.14 Add PI_EXT_INTEL_DEVICE_INFO_FREE_MEMORY as an extension for
// piDeviceGetInfo.
// 10.15 Add new PI_EXT_ONEAPI_QUEUE_LAZY_EXECUTION queue property

#define _PI_H_VERSION_MAJOR 10
#define _PI_H_VERSION_MINOR 14
#define _PI_H_VERSION_MINOR 15

#define _PI_STRING_HELPER(a) #a
#define _PI_CONCAT(a, b) _PI_STRING_HELPER(a.b)
Expand Down Expand Up @@ -569,7 +570,14 @@ constexpr pi_queue_properties PI_QUEUE_PROFILING_ENABLE = (1 << 1);
constexpr pi_queue_properties PI_QUEUE_ON_DEVICE = (1 << 2);
constexpr pi_queue_properties PI_QUEUE_ON_DEVICE_DEFAULT = (1 << 3);
constexpr pi_queue_properties PI_EXT_ONEAPI_QUEUE_DISCARD_EVENTS = (1 << 4);
constexpr pi_queue_properties PI_EXT_ONEAPI_QUEUE_LAZY_EXECUTION = (1 << 11);
// In a lazy queue, enqueued commands are not submitted for execution
// immediately, instead they are submitted for execution once the queue is
// flushed.
//
// This is to enable prototyping of the SYCL_EXT_ONEAPI_GRAPH extension,
// before a native command-list interface in PI can be designed and
// implemented.
constexpr pi_queue_properties PI_EXT_ONEAPI_QUEUE_LAZY_EXECUTION = (1 << 5);

using pi_result = _pi_result;
using pi_platform_info = _pi_platform_info;
Expand Down
2 changes: 1 addition & 1 deletion sycl/include/sycl/properties/queue_properties.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ namespace property {
namespace queue {
class discard_events
: public ::sycl::detail::DataLessProperty<::sycl::detail::DiscardEvents> {};
class lazy_execution
class lazy_execution
: public ::sycl::detail::DataLessProperty<::sycl::detail::LazyExecution> {};
} // namespace queue
} // namespace property
Expand Down

0 comments on commit 3073cfc

Please sign in to comment.