adding initial support for malloc/empty node #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
reviewed
Dec 21, 2022
Bensuo
reviewed
Dec 22, 2022
reble
commented
Jan 11, 2023
reble
commented
Jan 11, 2023
reble
commented
Jan 11, 2023
reble
commented
Jan 11, 2023
reble
commented
Jan 11, 2023
reble
changed the title
reble
commented
Jan 17, 2023
reble
commented
Jan 17, 2023
reble
commented
Jan 17, 2023
Bensuo
reviewed
Jan 18, 2023
sycl/source/detail/graph_impl.cpp
Outdated
| @@ -23,6 +25,14 @@ namespace experimental { | |||
| namespace detail { | |||
|
|
|||
| void graph_impl::exec(sycl::detail::queue_ptr q) { | |||
| for(auto i:MAllocs) { | |||
There was a problem hiding this comment.
Preference for a more descriptive name here than i.
reble
commented
Jan 18, 2023
EwanC
approved these changes
Jan 19, 2023
| @@ -23,6 +25,12 @@ namespace experimental { | |||
| namespace detail { | |||
|
|
|||
| void graph_impl::exec(sycl::detail::queue_ptr q) { | |||
| for(auto alloc:MAllocs) { | |||
There was a problem hiding this comment.
PR could use a clang-format, need some whitespace here (and other places) and some code added later is using 4-space indentation rather than 2.
sycl/test/graph/graph-memory.cpp
Outdated
| x[0] = v; | ||
| auto result = x[0]; | ||
|
|
||
| //sycl::free(x, q); |
There was a problem hiding this comment.
what happens if we try to call free here? I'd have thought if x was allocated on the execution of executable_graph that would still work. Might need a q.wait() after the submission.
sycl/test/graph/graph-memory.cpp
Outdated
|
|
||
| const size_t n = 1000; | ||
| float *x; | ||
| //void*& x = vec; |
There was a problem hiding this comment.
can remove commented out code
sycl/test/graph/graph-memory.cpp
Outdated
| q.submit([&](sycl::handler &h) { h.exec_graph(executable_graph); }); | ||
|
|
||
| float v = 2.0f; | ||
| //auto vec = static_cast<float*>(x); |
There was a problem hiding this comment.
can remove commented out code
|
Obsolete and superseded by #106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing some issues with the tests, have to track them down.