Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for multiple versions #9

Merged
merged 2 commits into from
Jul 2, 2023

Conversation

JonBoyleCoding
Copy link
Contributor

I added in my own repository the ability for the flake to handle multiple versions via overrideAttrs. It obviously requires a hash for each version, so I've added in all the ones I've had access to.

This might cause issues if you need a different setup script for each version... But as far as I could tell there was little that would cause an issue at the moment.

Don't know if you want this, but thought I would submit a PR in case you do!

@reckenrode
Copy link
Owner

Thanks for the contribution.

I’m getting to a point with NixOS/nixpkgs#234710 where I’m mostly just waiting on PRs to be merged. I have some time in the coming weeks when I should start being able to make some progress on #6. I’m going to merge this so users can stay updated and use a particular version more easily.

@reckenrode reckenrode merged commit 6cc3a47 into reckenrode:main Jul 2, 2023
@mfenniak
Copy link
Contributor

mfenniak commented Jul 4, 2023

Just wanted to share a thought looking at this -- there might be unexpected compatibility issues in this PR since node.js dependencies from different versions are being used.

If it works, it works -- but I suspect some different handling might be needed in the long-term as more divergence in the dependencies occurs. :-) I know you mentioned some plans in #6 though; hopefully that would help.

@reckenrode
Copy link
Owner

My plan for #6 is to have separate attributes (foundryvtt_9, foundryvtt_10, foundryvtt_11, etc) for those who need specific versions with foundryvtt defaulting to the latest stable. They’ll use whatever dependencies are appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants