Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Error in integration tests with SASRec #1616

Closed
miguelgfierro opened this issue Jan 19, 2022 · 1 comment
Closed

[BUG] Error in integration tests with SASRec #1616

miguelgfierro opened this issue Jan 19, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@miguelgfierro
Copy link
Collaborator

Description

we got this error in the nightly integration tests:

tests/integration/examples/test_notebooks_gpu.py ..............F         [100%]

=================================== FAILURES ===================================
_ test_sasrec_quickstart_integration[/recsys_data/RecSys/SASRec-tf2/data/-1-128-expected_values0-42] _

notebooks = {'als_deep_dive': '/home/recocat/myagent/_work/1/s/examples/02_model_collaborative_filtering/als_deep_dive.ipynb', 'al...p_dive': '/home/recocat/myagent/_work/1/s/examples/02_model_collaborative_filtering/cornac_bivae_deep_dive.ipynb', ...}
output_notebook = 'output.ipynb', kernel_name = 'python3'
data_dir = '/recsys_data/RecSys/SASRec-tf2/data/', num_epochs = 1
batch_size = 128, expected_values = {'Hit@10': 0.4244, 'ndcg@10': 0.2626}
seed = 42

    @pytest.mark.gpu
    @pytest.mark.integration
    @pytest.mark.parametrize(
        "data_dir, num_epochs, batch_size, expected_values, seed",
        [
            (
                "/recsys_data/RecSys/SASRec-tf2/data/",
                1,
                128,
                {"ndcg@10": 0.2626, "Hit@10": 0.4244},
                42,
            )
        ],
    )
    def test_sasrec_quickstart_integration(
        notebooks,
        output_notebook,
        kernel_name,
        data_dir,

link: https://dev.azure.com/best-practices/recommenders/_build/results?buildId=56130&view=logs&j=11a98e2c-5412-5289-91fd-519c9484010b&t=bd06083a-594e-5d8b-fa42-0b1a3b2f6a78

In which platform does it happen?

How do we replicate the issue?

Expected behavior (i.e. solution)

Other Comments

FYI @anargyri @aeroabir

@miguelgfierro miguelgfierro added the bug Something isn't working label Jan 19, 2022
@anargyri anargyri mentioned this issue Jan 19, 2022
4 tasks
@anargyri
Copy link
Collaborator

anargyri commented Jan 19, 2022

I fixed this error in #1617.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants