Update for Python 3.8 #1617
Update for Python 3.8 #1617
Conversation
anargyri
requested review from
gramhagen,
loomlike,
miguelgfierro and
wutaomsft
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @pytest.mark.notebooks | ||
| @pytest.mark.gpu | ||
| def test_sasrec_single_node_runs(notebooks, output_notebook, kernel_name): | ||
| notebook_path = notebooks["sasrec_quickstart"] | ||
| pm.execute_notebook(notebook_path, output_notebook, kernel_name=kernel_name) |
There was a problem hiding this comment.
quick question, is there a similar test in smoke or integration?
There was a problem hiding this comment.
Yes, there is one in integration (the same notebook). I removed this one because it took about 90 minutes to complete.
There was a problem hiding this comment.
The integration test is quite slow (2h 20 mins).
I need to check smoke and integration tests too, tomorrow. |
Smoke tests pass (except the difference in AUC in mmlspark lightgbm notebook). |
Codecov Report
@@ Coverage Diff @@
## staging #1617 +/- ##
===========================================
- Coverage 59.12% 56.68% -2.44%
===========================================
Files 88 88
Lines 8942 8956 +14
===========================================
- Hits 5287 5077 -210
- Misses 3655 3879 +224
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Integration tests pass too. |
Description
Related Issues
#1616
Checklist:
staging branchand not tomain branch.