-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding mind competition link to readme #1148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wutaomsft
reviewed
Jul 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The distinction between "What's New" and the "regular" section is not very clear. Suggest using a more prominent separator after What's New. Also suggest move the "Recommenders" header down, after What's New.
- Text: making some edits
some edits on the text
miguelgfierro
approved these changes
Jul 20, 2020
gramhagen
added a commit
that referenced
this pull request
Jul 21, 2020
* optimize dkn * fix bug in prediction * update notebook * add use entity parameter * change notebook * update a quick start on MINDsmall dataset * Gramhagen/xlearn docker fix (#1146) * moving cmake installation later in docker so it is available for all versions, also switching to just use aptitude * updating setup instructions for xlearn cmake dependency * reverting vscode auto-formatting of setup.md table of contents * fix bug and change his_size to history size * fix bug his_size to history size * Update dkn_MIND_dataset.ipynb Minor grammatical edits. * change his_size to history_size in notebook * adding mind competition link to readme (#1148) * adding mind competition link to readme * Update README.md some edits on the text * adding intro section in readme * removing divider in readme * Update README.md Co-authored-by: wutaomsft <[email protected]> Co-authored-by: Miguel González-Fierro <[email protected]> Co-authored-by: FAREAST\v-danyal <[email protected]> Co-authored-by: Miguel González-Fierro <[email protected]> Co-authored-by: Andreas Argyriou <[email protected]> Co-authored-by: wutaomsft <[email protected]> Co-authored-by: LeavingSeason <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adding what's new section to readme and adding mind competition link to readme
Related Issues
Checklist:
staging
and notmaster
.