Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staging to main for negative sampling fix #1298

Merged
merged 5 commits into from
Feb 11, 2021
Merged

Staging to main for negative sampling fix #1298

merged 5 commits into from
Feb 11, 2021

Conversation

miguelgfierro
Copy link
Collaborator

Description

Negative sampling fix

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@miguelgfierro miguelgfierro merged commit 1adb30a into main Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anargyri anargyri anargyri approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft

@yueguoguo yueguoguo Awaiting requested review from yueguoguo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miguelgfierro @anargyri @yueguoguo