[Transform] Do not create a new node if the existing node is already the correct one on AttributeKeyToClassConstFetchRector #5328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerethiX
commented
Dec 5, 2023
...ttribute/AttributeKeyToClassConstFetchRector/Fixture/not_replacing_existing_constant.php.inc
Outdated
Show resolved
Hide resolved
SerethiX
commented
Dec 5, 2023
rules/Transform/Rector/Attribute/AttributeKeyToClassConstFetchRector.php
Outdated
Show resolved
Hide resolved
|
The rule is configurable, you need to register in the config test when needed https://github.com/rectorphp/rector-src/blob/main/rules-tests/Transform/Rector/Attribute/AttributeKeyToClassConstFetchRector/config/configured_rule.php |
|
Please create at least 2 commits, first for failing test case, second for the fix so we know what it tries to fix |
|
@samsonasik Splitted into two commits as requested. |
samsonasik
reviewed
Dec 7, 2023
...ttribute/AttributeKeyToClassConstFetchRector/Fixture/not_replacing_existing_constant.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Dec 7, 2023
rules/Transform/Rector/Attribute/AttributeKeyToClassConstFetchRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Dec 7, 2023
...-tests/Transform/Rector/Attribute/AttributeKeyToClassConstFetchRector/Constants/Constant.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Dec 7, 2023
...ttribute/AttributeKeyToClassConstFetchRector/Fixture/not_replacing_existing_constant.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Dec 7, 2023
rules/Transform/Rector/Attribute/AttributeKeyToClassConstFetchRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Dec 7, 2023
rules/Transform/Rector/Attribute/AttributeKeyToClassConstFetchRector.php
Outdated
Show resolved
Hide resolved
SerethiX
commented
Dec 7, 2023
...ts/Transform/Rector/Attribute/AttributeKeyToClassConstFetchRector/Fixture/some_class.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
approved these changes
Dec 14, 2023
|
Please update PR title to something like: |
SerethiX
changed the title
|
Thank you @SerethiX |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in rectorphp/rector#8341 replacing the node, even if it leads to the same reference, forces a change, that is not required.
I added a check to skip recreating the node if the class reference stays the same.
During testing I found out, that resolving the value works differently based on if the referenced class actually exists or not.
So the added testfile currently passes the test, but only because the resolved value is not present as a key in the map.
Is there already a real class with constants that could be used, to make it a real test?