New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeQuality] Skip no @property doc on DynamicDocBlockPropertyToNativePropertyRector #6380

Merged

samsonasik merged 1 commit into main from skip-no-property-doc

Oct 12, 2024

Member

samsonasik commented Oct 12, 2024 •

edited

Loading

When no @property doc, it should be skipped, since current behaviour is only remove [\AllowDynamicProperties] but no add property, cause error:

PHP Deprecated:  Creation of dynamic property A::$x is deprecated in php shell code on line 1

because attribute removed, but property not added, see https://3v4l.org/aVOsR


          [CodeQuality] Skip no @Property doc on DynamicDocBlockPropertyToNativ…

befa3d1

…ePropertyRector

Member Author

samsonasik commented Oct 12, 2024

All checks have passed @TomasVotruba I am merging it ;)

samsonasik merged commit d180b8d into main

36 checks passed

samsonasik deleted the skip-no-property-doc branch

October 12, 2024 16:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet