Apply rector to the self .phpstorm.meta.php

[andrew-demb]

Extracted from #6592

[TomasVotruba]

I'm curious, what is a reason behind this change?

In the docs https://www.jetbrains.com/help/phpstorm/ide-advanced-metadata.html#expected-arguments, only static syntax is allowed.

[andrew-demb]

@TomasVotruba This is an automated change by Rector - after introducing "include dotfiles for withRootFiles" - Rector refactored this file.

Why rector refactored \PHPStan\PhpDocParser\Ast\Node::getAttribute() to the (new Node())->getAttribute() - because getAttribute is not a static method.

Should I add an ignore rule for .phpstorm.meta.php in rector.php?

[TomasVotruba]

I think we have to be more careful here.

How would this be handled in the wild? We don't want Rector breaking this file on next update.

[andrew-demb]

We can hardcode ignoring this filename in the withRootFiles to avoid applying rector to this file (which can not be interpreted by PHP)

[TomasVotruba]

Sounds good 👍

[andrew-demb]

Closed in favor #6594