Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Php74] Handle crash curly based array on trait on CurlyToSquareBracketArrayStringRector #6706

Merged
merged 2 commits into from
Jan 29, 2025
Merged

[Php74] Handle crash curly based array on trait on CurlyToSquareBracketArrayStringRector #6706

merged 2 commits into from
Jan 29, 2025

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Jan 29, 2025 •
edited
Loading

Fixes rectorphp/rector#8993

it cause error:

There was 1 error:

1) Rector\Tests\Php74\Rector\ArrayDimFetch\CurlyToSquareBracketArrayStringRector\CurlyToSquareBracketArrayStringRectorTest::test with data set #0 ('/Users/samsonasik/www/rector-...hp.inc')
Rector\Exception\ShouldNotHappenException: Node "PhpParser\Node\Expr\ArrayDimFetch" with is missing scope required for scope refresh

/Users/samsonasik/www/rector-src/src/Application/ChangedNodeScopeRefresher.php:50

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @robchett

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 60f9997 into main Jan 29, 2025
44 checks passed
@samsonasik samsonasik deleted the crash-curly-trait branch January 29, 2025 20:00
@robchett
Copy link

Thank you very much! That was so quick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when curly brace string accessor in a trait method
2 participants
@samsonasik @robchett