Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerfile: fix casing warning in Dockerfile #521

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

iamniting
Copy link
Member

Docker requires consistent casing for keywords.
If a keyword is in uppercase, all keywords should be in uppercase.
If a keyword is in lowercase, all keywords should be in lowercase.

The following warning appears while building images:

FromAsCasing: 'as' and 'FROM' keywords' casing do not match

Signed-off-by: Nitin Goyal [email protected]

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2025
@iamniting
Copy link
Member Author

/override ci/prow/ci-bundle-odf-operator-bundle
/override ci/prow/odf-operator-e2e-aws

Copy link
Contributor

openshift-ci bot commented Jan 29, 2025

@iamniting: Overrode contexts on behalf of iamniting: ci/prow/ci-bundle-odf-operator-bundle, ci/prow/odf-operator-e2e-aws

In response to this:

/override ci/prow/ci-bundle-odf-operator-bundle
/override ci/prow/odf-operator-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Docker requires consistent casing for keywords.
If a keyword is in uppercase, all keywords should be in uppercase.
If a keyword is in lowercase, all keywords should be in lowercase.

The following warning appears while building images:

FromAsCasing: 'as' and 'FROM' keywords' casing do not match

Signed-off-by: Nitin Goyal <[email protected]>
@iamniting
Copy link
Member Author

/override ci/prow/ci-bundle-odf-operator-bundle
/override ci/prow/odf-operator-e2e-aws

Copy link
Contributor

openshift-ci bot commented Jan 29, 2025

@iamniting: Overrode contexts on behalf of iamniting: ci/prow/ci-bundle-odf-operator-bundle, ci/prow/odf-operator-e2e-aws

In response to this:

/override ci/prow/ci-bundle-odf-operator-bundle
/override ci/prow/odf-operator-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@Nikhil-Ladha Nikhil-Ladha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2025
Copy link
Contributor

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, Nikhil-Ladha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0fec03e into red-hat-storage:main Jan 29, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants